Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev/wip 1139 title progress #1313

Merged
merged 15 commits into from
Sep 26, 2022
Merged

Dev/wip 1139 title progress #1313

merged 15 commits into from
Sep 26, 2022

Conversation

SuttArt
Copy link
Contributor

@SuttArt SuttArt commented Jun 16, 2022

see issue: #1139

Frontend Changes

  • Add reactive form control for Title in "Progress Dashboard widget"

Backend Changes

  • Send FormGroup from edit-progress-dashboard.component.ts with ProgressDashboardConfig.title and ProgressDashboardConfig.parts
  • Subscribe all data (title and parts) in progress-dashboard.component.ts

SuttArt added 3 commits May 28, 2022 01:37
@SuttArt
Init
7d34354
@SuttArt
status: not done
1e8fb03
@SuttArt
Fix title of Progress Dashboard widget
bd00743 
Delete EditProgressDashboardComponentData from
edit-progress-dashboard.component.ts
@github-actions
Copy link

Deployed to https://test-deployment-pr-1313.herokuapp.com/

@SuttArt SuttArt requested a review from sleidig June 16, 2022 18:14
TheSlimvReal
TheSlimvReal requested changes Jun 20, 2022
View reviewed changes
Copy link
Collaborator

@TheSlimvReal TheSlimvReal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good and simple approach, works very seamlessly.

I think it should be more visible that the title can be edited. The typical styling of the MatInput is missing there, maybe due to the usage of <h1>. Can you check if there is a easy way to make the title look editable?

SuttArt added 2 commits June 23, 2022 19:31
@SuttArt
Merge branch 'master' into dev/wip-1139-title-progress
13b4373
@SuttArt
Fix Title make visually more editable
1efb90e 
Add mat-form-field with class title-field. At .title-field width: 100%
@SuttArt
Copy link
Contributor Author

SuttArt commented Jun 23, 2022 •
edited
Loading

Good and simple approach, works very seamlessly.

I think it should be more visible that the title can be edited. The typical styling of the MatInput is missing there, maybe due to the usage of <h1>. Can you check if there is a easy way to make the title look editable?

I forgot to add mat-form-field. Is it better now?
I'm not sure about class title-field. I just added there width: 100%. I think adding a grid-system is too complicated for this.

@SuttArt SuttArt closed this Jun 23, 2022
@SuttArt SuttArt reopened this Jun 23, 2022
@github-actions
Copy link

Deployed to https://test-deployment-pr-1313.herokuapp.com/

@SuttArt SuttArt requested a review from TheSlimvReal June 23, 2022 18:23
SuttArt added 2 commits June 23, 2022 21:37
@SuttArt
Fix unit test
31087a6 
Delete <h1> from title, add font-size: 32px
Fix unit test. Do not added new cases
@SuttArt
Fix unit tests
043fde3 
Add new test step for "title"
@sonarcloud
Copy link

sonarcloud bot commented Jun 30, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

TheSlimvReal
TheSlimvReal reviewed Jul 4, 2022
View reviewed changes
Copy link
Collaborator

@TheSlimvReal TheSlimvReal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, just some small cleanup ideas

.../progress-dashboard-widget/edit-progress-dashboard/edit-progress-dashboard.component.spec.ts Outdated Show resolved Hide resolved
...res/progress-dashboard-widget/edit-progress-dashboard/edit-progress-dashboard.component.html Show resolved Hide resolved
...res/progress-dashboard-widget/edit-progress-dashboard/edit-progress-dashboard.component.html Outdated Show resolved Hide resolved
...tures/progress-dashboard-widget/edit-progress-dashboard/edit-progress-dashboard.component.ts Outdated Show resolved Hide resolved
@SuttArt
Fix Title is required
ffdf5da 
Add <mat-error>; Delete get tooltipOnSave()
@snyk-bot snyk-bot mentioned this pull request Sep 19, 2022
Merged
SuttArt and others added 7 commits September 22, 2022 19:48
@SuttArt
Merge branch 'master' into dev/wip-1139-title-progress
87597f3 
# Conflicts:
#	src/app/features/progress-dashboard-widget/edit-progress-dashboard/edit-progress-dashboard.component.spec.ts
#	src/app/features/progress-dashboard-widget/edit-progress-dashboard/edit-progress-dashboard.component.ts
@SuttArt
merged with master
6b5fd6f
@TheSlimvReal
cleaning up component
dbbfde9
@TheSlimvReal
added form type
6b2fd65
@TheSlimvReal
added helper type library for typed angular forms
b504c1d
@TheSlimvReal
cleaned up some code
2a05a19
@TheSlimvReal
Merge branch 'master' into dev/wip-1139-title-progress
58df85c
@sonarcloud
Copy link

sonarcloud bot commented Sep 26, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

TheSlimvReal
TheSlimvReal approved these changes Sep 26, 2022
View reviewed changes
Copy link
Collaborator

@TheSlimvReal TheSlimvReal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work. Thank you for implementing this feature!

@TheSlimvReal TheSlimvReal merged commit 3939e52 into master Sep 26, 2022
@TheSlimvReal TheSlimvReal deleted the dev/wip-1139-title-progress branch September 26, 2022 15:02
@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.11.1-master.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.11.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheSlimvReal TheSlimvReal TheSlimvReal approved these changes

@sleidig sleidig Awaiting requested review from sleidig

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SuttArt @aam-digital-ci @TheSlimvReal