fix(core): using correct timezone when parsing dates #1355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deployed to https://test-deployment-pr-1355.herokuapp.com/ |
sleidig
reviewed
Jul 11, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
|
🎉 This PR is included in version 3.8.2-master.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 3.8.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To test the issue on the current version:
UTC-0600ChildSchoolRelation(child -> education)This is because
new Date("2022-01-01")is interpreted as UTC time. Converting this toUTC-0600results in 6pm the day before (2021-12-31).The very simple fix to this is to instead use a different date constructor:
new Date(2022, 0, 1)is interpreted as first of January 2022 in the local time.Visible/Frontend Changes
--
Architectural/Backend Changes
date-onlyandmonthare interpreted with the local timezone