Display entity improvements #1370
Conversation
…ovements # Conflicts: # src/app/app.routing.ts # src/app/utils/test-utils/generic-matchers.spec.ts
|
Deployed to https://test-deployment-pr-1370.herokuapp.com/ |
| @@ -1,4 +1,7 @@ | |||
| <span [ngClass]="{ clickable: !linkDisabled }"> | |||
| <div | |||
There was a problem hiding this comment.
I think this was "" for a reason - otherwise it can't be displayed inline properly, which we do at some occasions? Admittedly, I didn't find any UI issue in the PR deployment now, so maybe this is not relevant any more. But I do remember I explicitly changed this to span a while back.
There was a problem hiding this comment.
I guess the recent style improvements made this not required any more
|
Kudos, SonarCloud Quality Gate passed!
|
|
🎉 This PR is included in version 3.8.3-master.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 3.8.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
The usage of the
ChildBlockComponent,SchoolBlockComponentandDisplayEntityComponentcurrently leads to inconsistent behavior for things that look the same. Sometimes there is a hover, sometimes the cursor becomes a pointer, sometimes it's clickable.The approach here is to generally use the
DisplayEntityComponentand also let it handle the click, hover and pointer logic.The ...Block components are only dynamically inserted based on the entity which is displayed.
Visible/Frontend Changes
Architectural/Backend Changes
/usersand/users/:idto/userand/user/:idto be consistent with other entity types. MIGRATION REQUIRED