fix: permissions are correctly applied in popup form #1387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deployed to https://test-deployment-pr-1387.herokuapp.com/ |
sleidig
approved these changes
Aug 3, 2022
src/app/child-dev-project/schools/activities-overview/activities-overview.component.ts
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed!
|
|
🎉 This PR is included in version 3.9.0-master.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 3.9.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the row details component evaluates
updatepermissions on the input entity. When clicking the+button on a table a new entity is created which can result in the popup being in disabled mode (e.g. a entity needs to have a certain value for the user to haveupdatepermissions).This is fixed by detecting, whether the entity is currently being created or updated.
Also, I discovered a small but in the
ActivitiesOverviewComponent:This happens because the newly created entity is not present in the
recordsarray of theActivitiesOverviewComponent.Visible/Frontend Changes
RowDetailsComponentis never disabled when creating a entityArchitectural/Backend Changes
--