Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assets request still work with a locale in the path #1397

Merged
merged 1 commit into from
Aug 15, 2022

Conversation

TheSlimvReal
Copy link
Collaborator

When updating an instance to the new master, the first login results in a broken state because /en-US/assets/config.json does not exist anymore. This can be solved by forwarding the relative asset requests to the single assets folder.

Visible/Frontend Changes

  • [x]
  • [ ]

Architectural/Backend Changes

  • [x]
  • [ ]

@github-actions
Copy link

@sonarcloud
Copy link

sonarcloud bot commented Aug 15, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@TheSlimvReal TheSlimvReal merged commit 5cd2e5d into master Aug 15, 2022
@TheSlimvReal TheSlimvReal deleted the assets-fallback branch August 15, 2022 18:20
@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.9.0-master.7 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.9.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants