Notes of schools and authors #1431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deployed to https://test-deployment-pr-1431.herokuapp.com/ |
sleidig
reviewed
Sep 8, 2022
Comment on lines
+63
to
+67
| this.entity = config.entity; | ||
| const entityType = this.entity.getType(); | ||
| this.noteProperty = [...Note.schema.keys()].find( | ||
| (prop) => Note.schema.get(prop).additional === entityType | ||
| ); |
There was a problem hiding this comment.
impressive solution 😃 took me a second to even understand why this works
|
closes #1423 ? |
|
Kudos, SonarCloud Quality Gate passed!
|
|
🎉 This PR is included in version 3.10.2-master.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 3.11.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 3.11.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #1423
The current
NotesOfChildcomponent only allows to show notes that are linked to a child.This component has been made more abstract to also support notes of a school or notes of an author.
Currently the component is still called
NotesOfChild. This name should be changed in the future to something likeRelatedNotes. I have left it for now because I want to get this PR out fast and a change of the name would require a migration of existing configs.Visible/Frontend Changes
--
Architectural/Backend Changes
NotesOfChildcan be used in school and user details components