Configurable date range filter for entity lists #1487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/app/core/entity-components/entity-list/filter-generator.service.ts
Outdated
Show resolved
Hide resolved
…ange-filter-for-Entity-Lists
…ange-filter-for-Entity-Lists
Co-authored-by: Sebastian <sleidig@users.noreply.github.com>
…ange-filter-for-Entity-Lists
…Lists # Conflicts: # package-lock.json
…ange-filter-for-Entity-Lists # Conflicts: # src/app/core/entity-components/entity-list/EntityListConfig.ts
…Lists # Conflicts: # src/app/app.module.ts # src/app/core/entity-components/entity-details/entity-details.module.ts # src/app/core/entity-components/entity-list/EntityListConfig.ts # src/app/core/filter/filter.module.ts
…ange-filter-for-Entity-Lists
…ange-filter-for-Entity-Lists
…ange-filter-for-Entity-Lists
|
Deployed to https://pr-1487.aam-digital.net/ |
…date range filter panel
… to test the constructor
|
The test for the indexOfCorrespondingDateRange is quite incomplete and inadequate, but apart from that this PR could probably soon be reviewed, @TheSlimvReal. |
|
Kudos, SonarCloud Quality Gate passed!
|
TheSlimvReal
approved these changes
Jun 28, 2023
|
🎉 This PR is included in version 3.22.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Date range filters can now be configured via the
config-fix.ts, as described in #1448.Configuration via UI, as described in #1383 is also implemented.