Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace custom user-account component with the "normal" user view #1622

Closed
sleidig opened this issue Jan 2, 2023 · 4 comments
Closed

replace custom user-account component with the "normal" user view #1622

sleidig opened this issue Jan 2, 2023 · 4 comments

Comments

@sleidig
Copy link
Member

sleidig commented Jan 2, 2023

Clicking on the (hard-coded) "profile" button leads users to the user account component that allows to change the password but does not show any other details of the user entity. Also, as this is a custom component, the layout has some problems (scroll bars) that are fixed for the entity-details view. It would make sense to show users the same user view that admins see and reduce the custom code needed here. (if necessary, the password change logic could go into a component that does not include the tabbed interface but just those fields).

@sleidig sleidig moved this from Triage to Todo [community help wanted] in All Tasks & Issues Sep 20, 2023
@sleidig sleidig moved this from Todo [help wanted] to In Progress in All Tasks & Issues Jan 5, 2024
@sleidig
Copy link
Member Author

sleidig commented Jan 23, 2024

@TheSlimvReal will this be worked upon as part of the work allowing accounts for different entity types? #2143

@sleidig sleidig added this to the Login for other entities milestone Jan 23, 2024
@TheSlimvReal
Copy link
Collaborator

Not necessarily yet. At the moment these views still serve a quite different purpose (managing other accounts vs managing the own account) so nothing to be changed about this yet. Not to sure how relevant it is though (besides the difficulty to distinguish the two by names)

@sleidig sleidig moved this from In Progress to Todo [help wanted] in All Tasks & Issues Jan 26, 2024
@TheSlimvReal
Copy link
Collaborator

I think this is less and less practical. Especially when we now add the link to the entity to the UserAccountComponent we have another difference between those components. For now I do not see a practical way to combine these two components (the only overlap is the "email" field).
In the future we can rather check whether we can use Keycloaks account UI (.../realms/{realm}/account) which would come with all the features we would want there. However that needs quite some styling.

@sleidig
Copy link
Member Author

sleidig commented Feb 8, 2024

Agreed. With the split of the user entity from the account, the link we have now should be enough. Closing this

@sleidig sleidig closed this as completed Feb 8, 2024
@github-project-automation github-project-automation bot moved this from Todo [help wanted] to Done in All Tasks & Issues Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants