user-editable dropdowns #1661
Merged
user-editable dropdowns #1661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for easier re-use and testing
sleidig
force-pushed
the
user-conf-enum
branch
from
a3e2db5 to
024fa11
Compare
…ocomplete form field component
TheSlimvReal
requested changes
Jan 17, 2023
src/app/core/configurable-enum/basic-autocomplete/basic-autocomplete.component.html
Outdated
Show resolved
Hide resolved
src/app/core/configurable-enum/basic-autocomplete/basic-autocomplete.component.html
Outdated
Show resolved
Hide resolved
src/app/core/configurable-enum/basic-autocomplete/basic-autocomplete.component.html
Outdated
Show resolved
Hide resolved
src/app/core/configurable-enum/basic-autocomplete/basic-autocomplete.component.html
Outdated
Show resolved
Hide resolved
src/app/core/configurable-enum/basic-autocomplete/basic-autocomplete.component.spec.ts
Outdated
Show resolved
Hide resolved
...re/entity-components/entity-utils/dynamic-form-components/edit-number/edit-number.stories.ts
Outdated
Show resolved
Hide resolved
|
Deployed to https://pr-1661.aam-digital.net/ |
sleidig
commented
Jan 24, 2023
There was a problem hiding this comment.
Nice work!
The delay until "Add option xxx" is shown is confusing me - why did you decide against showing that in real-time?
I tuned the popup UI a bit to make it more consistent with other views. I would also like the option to cancel an edit - probably best to use reactiveForms then? (UI is there now but the logic is not because we use two-way binding currently)
src/app/core/configurable-enum/basic-autocomplete/basic-autocomplete.component.html
Outdated
Show resolved
Hide resolved
src/app/core/configurable-enum/edit-enum-popup/edit-enum-popup.component.ts
Outdated
Show resolved
Hide resolved
src/app/core/configurable-enum/enum-dropdown/enum-dropdown.component.html
Outdated
Show resolved
Hide resolved
src/app/core/configurable-enum/edit-enum-popup/edit-enum-popup.component.ts
Outdated
Show resolved
Hide resolved
sleidig
commented
Feb 3, 2023
There was a problem hiding this comment.
Code looks pretty good now! :-)
- I could/did not test migration but already migrated instances seem stable now.
- One error on saving with newly created option:
- create a new option
- --> the new value is correctly displayed in the field
- save the entity form
- go back to list and re-open that entity's details
- --> the value is not set
- (re-selecting it now and saving seems to work)
...ttendance/dashboard-widgets/attendance-week-dashboard/attendance-week-dashboard.component.ts
Show resolved
Hide resolved
src/app/core/configurable-enum/basic-autocomplete/basic-autocomplete.component.spec.ts
Outdated
Show resolved
Hide resolved
src/app/core/configurable-enum/basic-autocomplete/basic-autocomplete.component.ts
Outdated
Show resolved
Hide resolved
src/app/core/configurable-enum/configure-enum-popup/configure-enum-popup.component.ts
Outdated
Show resolved
Hide resolved
src/app/core/configurable-enum/configure-enum-popup/configure-enum-popup.component.ts
Outdated
Show resolved
Hide resolved
src/app/core/configurable-enum/display-configurable-enum/display-configurable-enum.component.ts
Outdated
Show resolved
Hide resolved
…mplete.component.ts Co-authored-by: Sebastian <sebastian.leidig@gmail.com>
…enum-popup.component.ts Co-authored-by: Sebastian <sebastian.leidig@gmail.com>
…enum-popup.component.ts Co-authored-by: Sebastian <sebastian.leidig@gmail.com>
sleidig
commented
Feb 7, 2023
There was a problem hiding this comment.
I still see the functional issue described before:
- create a new option
- --> the new value is correctly displayed in the field
- save the entity form
- go back to list and re-open that entity's details
- --> the value is not set
- (re-selecting it now and saving seems to work)
sleidig
commented
Feb 7, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
TheSlimvReal
approved these changes
Feb 7, 2023
|
🎉 This PR is included in version 3.18.0-master.9 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 3.18.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see issue: #1642