Support all entity types in reports #1711
Conversation
# Conflicts: # src/app/core/export/query.service.ts
|
Deployed to https://pr-1711.aam-digital.net/ |
There was a problem hiding this comment.
Code looks good and basic reports tested successfully for a custom extended entity type
feel free to have a look at PR #1216 also and close, amend or finish that one, if it seems feasible after having picked up this topic in general 😊
|
@sleidig updates of the cache are now also implemented. Please have a look at the new changes |
| this.entityInfo[ENTITY_TYPE].updating = true; | ||
| this.entityMapper | ||
| .receiveUpdates(ENTITY_TYPE) | ||
| .subscribe(({ entity, type }) => { |
There was a problem hiding this comment.
will this not re-subscribe to the same entity type updates after a broader date range of that type is loaded?
And in general, when are we cleaning up these subscriptions? (or if we don't yet, shouldn't we clear that cache at some time rather than keeping all that stuff in memory forever after a user once used a report?)
There was a problem hiding this comment.
No, the updating flag is only set to true once and after that this entity type will always be filtered out here.
Generally, there is no concept of cleaning up yet as this service lives outside of the component.
A option would be to just clear the cache once the user leaves the site but then this whole caching concept was pointless (as you can make changes without going away from the reporting page).
|
Kudos, SonarCloud Quality Gate passed!
|
|
🎉 This PR is included in version 3.18.1-master.5 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 3.18.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
see issue: #1682
Visible/Frontend Changes
--
Architectural/Backend Changes