fix: reports only show actual participants of events #1723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deployed to https://pr-1723.aam-digital.net/ |
…the day of the note
sleidig
approved these changes
Feb 14, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
|
🎉 This PR is included in version 3.18.1-master.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 3.18.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our logic to load notes, we currently always also update the participants list with new people that joined the group. This is useful in the roll call setup where you might want to also record their attendance stats. In other places where we only report the attendance without the option to modify it, this is not very useful as it will just add empty information (e.g. reports, dashboard components). This functionality has now been split up into two functions, one just loading the notes and one where the new participants are also added.
Another problem that I discovered is that the active participants are added based on the active status of today, not for the actual day where e.g. the roll call is conducted. This means also participants that have a start date of today would then be included when doing a roll call yesterday. This has also been fixed.
Visible/Frontend Changes
Architectural/Backend Changes