Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removed "show all" button in tables to improve performance #1795

Merged
merged 2 commits into from
Mar 29, 2023

Conversation

TheSlimvReal
Copy link
Collaborator

It can have very bad impacts on the performance when a few hundred rows are displayed in a table. This limits the page size to a maximum of 100.

Visible/Frontend Changes

  • Remove show all button for tables

Architectural/Backend Changes

--

@github-actions
Copy link
Contributor

Deployed to https://pr-1795.aam-digital.net/

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sleidig sleidig changed the title fix: removed all button in tables to improve performance fix: removed "show all" button in tables to improve performance Mar 28, 2023
@TheSlimvReal TheSlimvReal merged commit 6c75410 into master Mar 29, 2023
@TheSlimvReal TheSlimvReal deleted the page_size_limit branch March 29, 2023 12:05
@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.20.0-master.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.20.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants