Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic autocomplete should not require strict equality #1805

Open
TheSlimvReal opened this issue Apr 4, 2023 · 0 comments
Open

Basic autocomplete should not require strict equality #1805

TheSlimvReal opened this issue Apr 4, 2023 · 0 comments
Labels
Type: Refactoring / Technical Enh. Technical Enhancement without changes for the user

Comments

@TheSlimvReal
Copy link
Collaborator

The autocomplete component uses strict equality checks (===) to check whether an option is currently selected. This works well when strings or numbers are the values but in case of object (e.g. configurable enums) this requires absolute object identity.

This is a problem when we create deep copies of objects because they will fail this equality check. As it is difficult to always remember which objects should be deeply copied and which not, it would be better if this strict equality is not necessary and we rather have a logical equality that e.g. only checks the id property of a configurable enum.

@TheSlimvReal TheSlimvReal added the Type: Refactoring / Technical Enh. Technical Enhancement without changes for the user label Apr 4, 2023
@TheSlimvReal TheSlimvReal mentioned this issue Apr 4, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Refactoring / Technical Enh. Technical Enhancement without changes for the user
Projects
Status: Triage / Analysis
Development

No branches or pull requests

1 participant