Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrating date to date-only (to ensure consistent report results) #1826

Merged
merged 5 commits into from
May 8, 2023
Merged

migrating date to date-only (to ensure consistent report results) #1826

merged 5 commits into from
May 8, 2023

Conversation

sleidig
Copy link
Member

@sleidig sleidig commented Apr 13, 2023 •
edited
Loading

see issue: #1807 (maybe related #978 )

  • date values are migrated to the (timezone offset adjusted) date-only values during loading
  • make date-only the default dataType for Date objects?

@sleidig sleidig marked this pull request as draft April 13, 2023 18:05
@github-actions
Copy link

Deployed to https://pr-1826.aam-digital.net/

@sleidig sleidig marked this pull request as ready for review May 3, 2023 09:52
@sleidig sleidig changed the title [WIP] migrating date to date-only (to ensure consistent report results) migrating date to date-only (to ensure consistent report results) May 3, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sleidig sleidig linked an issue May 3, 2023 that may be closed by this pull request
timezone influences reporting stats of events #1807
Closed
@TheSlimvReal TheSlimvReal merged commit 63643ce into master May 8, 2023
@TheSlimvReal TheSlimvReal deleted the report-timezones branch May 8, 2023 09:49
@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.21.1-master.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.21.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheSlimvReal TheSlimvReal TheSlimvReal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
All Tasks & Issues
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

timezone influences reporting stats of events
3 participants
@sleidig @aam-digital-ci @TheSlimvReal