Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: demo data initialisation #1831

Merged
merged 3 commits into from
Apr 18, 2023
Merged

fix: demo data initialisation #1831

merged 3 commits into from
Apr 18, 2023

Conversation

TheSlimvReal
Copy link
Collaborator

Publishing the demo config last so the app only initialises after all other entities have been saved.
Currently, some dashboard components stay empty on first load and a refresh on school details sometimes results in a not found error.

Visible/Frontend Changes

  • demo data is better initialised

Architectural/Backend Changes

--

@github-actions
Copy link
Contributor

Deployed to https://pr-1831.aam-digital.net/

@TheSlimvReal TheSlimvReal changed the title fix: fix demo initialisation fix: demo data initialisation Apr 17, 2023
Copy link
Member

@sleidig sleidig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good find!

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sleidig sleidig merged commit f9d455f into master Apr 18, 2023
@sleidig sleidig deleted the demo_fix branch April 18, 2023 13:48
@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.20.1-master.7 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.20.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants