Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: editing entity array correctly marks a form as dirty #1869

Merged
merged 1 commit into from
May 2, 2023
Merged

fix: editing entity array correctly marks a form as dirty #1869

merged 1 commit into from
May 2, 2023

Conversation

TheSlimvReal
Copy link
Collaborator

Save button is disabled in note details if only an entity-array field is changed.

Visible/Frontend Changes

  • [x]
  • [ ]

Architectural/Backend Changes

  • [x]
  • [ ]

@github-actions
Copy link

Deployed to https://pr-1869.aam-digital.net/

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sleidig
sleidig approved these changes May 2, 2023
View reviewed changes
Copy link
Member

@sleidig sleidig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to review the EditEntityArrayComponent and EntitySelectComponent and see whether we want implement them similar to EditSingleEntity using the BasicAutocompleteComponent. Not sure this would work but my first instinct was to wonder why entity array is different from entity single

@sleidig sleidig merged commit 3fe12a1 into master May 2, 2023
@sleidig sleidig deleted the entity_array_form_dirty branch May 2, 2023 08:54
@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.21.0-master.7 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.21.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sleidig sleidig sleidig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
All Tasks & Issues
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TheSlimvReal @aam-digital-ci @sleidig