Login with Keycloak UI #1990
Merged
Login with Keycloak UI #1990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deployed to https://pr-1990.aam-digital.net/ |
sleidig
requested changes
Oct 23, 2023
There was a problem hiding this comment.
Code looks good to me 💯
Functional Testing including 2FA
(on dev.aam-digital.net - some things may just be configuration issues):
- 2FA via email code works really smoothly and the "remember device" option is super useful 😃
- no "forgot password" option on (keycloak) login form
- 2FA email with codes could have a slightly more elaborate email template (maybe a footer stating the system name in the body - where are these templates maintained?)
- make keycloak login light orange background also white? (considering our recent UI background switch, and the fact that the color scheme of the app might have been customized to other colors)
- trying login with "demo-admin" somehow puts me into a "We are sorry ... invalid username or password" screen without any chance to try with different password (console logs a 400 Bad Request)
- on slow devices and connections the offline login section becomes available even before the "re-check" of login after an online login is complete. Maybe we need to increase the timeout a bit further?
offline login section should be available immediately if the device is completely offline (the "we couldn't connect to server" text is showing immediately, but the offline login option only appears with the delay).seems to have been an issue with my throttling - upon reload it works as expected- Also, I would maybe just disable the offline login section instead of not displaying it at all?
- Do we have documentation about how to set this up (and possible adjust the keycloak setup)?
sleidig
approved these changes
Oct 23, 2023
# Conflicts: # src/index.html
TheSlimvReal
force-pushed
the
keycloak_login
branch
from
f7d50d5 to
9f3a133
Compare
# Conflicts: # package-lock.json # package.json # src/assets/locale/messages.de.xlf # src/assets/locale/messages.fr.xlf # src/assets/locale/messages.it.xlf # src/assets/locale/messages.xlf
# Conflicts: # package-lock.json
TheSlimvReal
force-pushed
the
keycloak_login
branch
from
fa2c2f2 to
83a7ba9
Compare
# Conflicts: # package-lock.json
# Conflicts: # package-lock.json # src/app/core/basic-datatypes/entity/edit-single-entity/edit-single-entity.component.scss # src/app/core/session/login/login.component.scss # src/app/core/ui/navigation/navigation/navigation.component.scss
|
🎉 This PR is included in version 3.27.0-master.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 3.27.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #1342
Open questions