Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reports are own entities #2106

Merged
merged 8 commits into from
Dec 5, 2023
Merged

fix: reports are own entities #2106

merged 8 commits into from
Dec 5, 2023

Conversation

TheSlimvReal
Copy link
Collaborator

@TheSlimvReal TheSlimvReal commented Nov 27, 2023

closes: #2104

MIGRATION REQUIRED -> See Aam-Digital/ndb-admin#15

Copy link

Deployed to https://pr-2106.aam-digital.net/

@TheSlimvReal TheSlimvReal requested a review from sleidig November 28, 2023 10:20
@TheSlimvReal TheSlimvReal marked this pull request as ready for review November 28, 2023 17:12
Copy link
Member

@sleidig sleidig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clear and simple. 👍
Functionality seems unaffected (only tested in mock mode).

Do we want/need an automated migration via admin backend?

src/app/features/reporting/report-config.ts Show resolved Hide resolved
@TheSlimvReal TheSlimvReal merged commit d742e69 into master Dec 5, 2023
8 checks passed
@TheSlimvReal TheSlimvReal deleted the report_refactor branch December 5, 2023 13:03
@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.27.2-master.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released on @master managed by CI (semantic-release) label Dec 5, 2023
@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.27.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released managed by CI (semantic-release) label Dec 8, 2023
@TheSlimvReal TheSlimvReal mentioned this pull request Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released on @master managed by CI (semantic-release) released managed by CI (semantic-release)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate report structure
3 participants