SQS Integration #2123
Merged
SQS Integration #2123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deployed to https://pr-2123.aam-digital.net/ |
This was
linked to
issues
Dec 7, 2023
sleidig
approved these changes
Dec 11, 2023
There was a problem hiding this comment.
Impressive how simple this code is 😃
From my quick testing in the PR deployment, the existing reports still seem to work fine.
Only the order in the dropdown of the reporting component had a designed logical order (most important/general first) which is now lost.
src/app/features/reporting/reporting/reporting.component.spec.ts
Outdated
Show resolved
Hide resolved
src/app/features/reporting/sql-report/sql-report.service.spec.ts
Outdated
Show resolved
Hide resolved
# Conflicts: # src/app/features/reporting/reporting/reporting.component.ts
sleidig
approved these changes
Dec 15, 2023
Co-authored-by: Sebastian <sebastian@aam-digital.com>
|
🎉 This PR is included in version 3.28.0-master.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 3.28.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #2117 #2105 #1887
"mode": "sql".SqlReportServiceSqlReportServiceautomatically creates and, if necessary, updates the SQS schema before sending the query request to the baceknd