Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent usage of superclass schema #2126

Merged
merged 1 commit into from
Dec 12, 2023
Merged

fix: prevent usage of superclass schema #2126

merged 1 commit into from
Dec 12, 2023

Conversation

TheSlimvReal
Copy link
Collaborator

If currently only the @DatabaseEntity property is used without any property being decorated with @DatabaseField, then the schema object from the superclass is used. This results in new properties also being added to the superclass's schema.

Copy link

Deployed to https://pr-2126.aam-digital.net/

Copy link
Member

@sleidig sleidig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for figuring this out! 🥇

@sleidig sleidig merged commit 1d2c877 into master Dec 12, 2023
9 checks passed
@sleidig sleidig deleted the schema_fix branch December 12, 2023 07:30
@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.27.3-master.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released on @master managed by CI (semantic-release) label Dec 12, 2023
@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.28.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released managed by CI (semantic-release) label Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released on @master managed by CI (semantic-release) released managed by CI (semantic-release)
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants