language setting #2136
Merged
language setting #2136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deployed to https://pr-2136.aam-digital.net/ |
sleidig
reviewed
Dec 20, 2023
src/app/core/language/language-select/language-select.component.ts
Outdated
Show resolved
Hide resolved
sleidig
reviewed
Dec 20, 2023
src/app/core/language/language-select/language-select.component.html
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Thanks for taking this up @sadaf895!
Just a small suggestion when first looking at this. I was first a bit confused by the icon as I think I have never seen it before in another application.
I think it is more common to use the globe icon or just show the abbreviation of the currently selected locale.
# Conflicts: # package-lock.json # package.json
|
🎉 This PR is included in version 3.28.0-master.8 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 3.28.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #XX
Visible/Frontend Changes
Architectural/Backend Changes