Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(schools): school list show a column stating the total number of participants #2152

Merged

Conversation

tomwwinter
Copy link
Contributor

@tomwwinter tomwwinter commented Jan 4, 2024

closes: #1277

Visible/Frontend Changes

  • new column in school list

Architectural/Backend Changes

  • none

Copy link

github-actions bot commented Jan 4, 2024

Deployed to https://pr-2152.aam-digital.net/

Copy link
Collaborator

@TheSlimvReal TheSlimvReal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finishing this so quickly, especially with the thorough testing.

The functionality is great, most comments comments are around code style.

@tomwwinter tomwwinter force-pushed the tw/feat/1277-number-of-active-participants-of-group branch from bc327f8 to 65c65ca Compare January 5, 2024 06:59
@tomwwinter tomwwinter force-pushed the tw/feat/1277-number-of-active-participants-of-group branch from 764aa97 to 8c757e4 Compare January 5, 2024 10:27
@tomwwinter tomwwinter merged commit 3f1ba97 into master Jan 5, 2024
7 checks passed
@tomwwinter tomwwinter deleted the tw/feat/1277-number-of-active-participants-of-group branch January 5, 2024 13:08
@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.28.0-master.7 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released on @master managed by CI (semantic-release) label Jan 5, 2024
@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.28.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released managed by CI (semantic-release) label Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released on @master managed by CI (semantic-release) released managed by CI (semantic-release)
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

column: number of active participants of group
3 participants