-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(schools): school list show a column stating the total number of participants #2152
feat(schools): school list show a column stating the total number of participants #2152
Conversation
Deployed to https://pr-2152.aam-digital.net/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for finishing this so quickly, especially with the thorough testing.
The functionality is great, most comments comments are around code style.
...ild-dev-project/schools/display-participants-count/display-participants-count.component.html
Outdated
Show resolved
Hide resolved
...child-dev-project/schools/display-participants-count/display-participants-count.component.ts
Outdated
Show resolved
Hide resolved
...child-dev-project/schools/display-participants-count/display-participants-count.component.ts
Outdated
Show resolved
Hide resolved
bc327f8
to
65c65ca
Compare
...child-dev-project/schools/display-participants-count/display-participants-count.component.ts
Outdated
Show resolved
Hide resolved
764aa97
to
8c757e4
Compare
🎉 This PR is included in version 3.28.0-master.7 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 3.28.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
closes: #1277
Visible/Frontend Changes
Architectural/Backend Changes