Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More bulk actions: bulk delete + bulk archive multiple records at once from list #2154

Merged
merged 16 commits into from
Feb 16, 2024

Conversation

christophscheuing
Copy link
Contributor

relates to: #2092

Copy link

github-actions bot commented Jan 4, 2024

Deployed to https://pr-2154.aam-digital.net/

@christophscheuing christophscheuing marked this pull request as ready for review February 8, 2024 20:32
@christophscheuing christophscheuing marked this pull request as draft February 8, 2024 20:33
@sleidig sleidig marked this pull request as ready for review February 12, 2024 16:58
Copy link
Member

@sleidig sleidig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good in code (although the message generation has some complex layers 😅 ) and works smoothly.

From Testing (almost all good):

  • bulk actions can be activated on EntityList and special lists like ChildrenList and trigger as expected
  • archive works
  • anonymize works
    • notification text problem: "[..] linked to ONLY these 2 Children have ."
  • delete works
  • undo of bulk action through snackbar works

Copy link
Member

@sleidig sleidig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@sleidig sleidig merged commit c642edf into master Feb 16, 2024
4 of 5 checks passed
@sleidig sleidig deleted the more_bulk_actions branch February 16, 2024 11:05
@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.32.0-master.8 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released on @master managed by CI (semantic-release) label Feb 16, 2024
@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.32.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released managed by CI (semantic-release) label Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released on @master managed by CI (semantic-release) released managed by CI (semantic-release)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants