-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More bulk actions: bulk delete + bulk archive multiple records at once from list #2154
Conversation
Deployed to https://pr-2154.aam-digital.net/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good in code (although the message generation has some complex layers 😅 ) and works smoothly.
From Testing (almost all good):
- bulk actions can be activated on EntityList and special lists like ChildrenList and trigger as expected
- archive works
- anonymize works
- notification text problem: "[..] linked to ONLY these 2 Children have ."
- delete works
- undo of bulk action through snackbar works
src/app/core/entity/entity-actions/entity-actions.service.spec.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
🎉 This PR is included in version 3.32.0-master.8 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 3.32.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
relates to: #2092