Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Count by entity in Dashboard #2205

Merged
merged 11 commits into from
Feb 1, 2024
Merged

Count by entity in Dashboard #2205

merged 11 commits into from
Feb 1, 2024

Conversation

sleidig
Copy link
Member

@sleidig sleidig commented Jan 29, 2024

closes: #2198 #2002

  • display entity block if grouped by entity field
  • check whether we can generalize the displaying using viewComponent instead of condition to use entity display
  • groupBy array properties, disaggregating summed up for each individual item (e.g. per category, also supporting multiple categories in the counted entities)

Copy link

Deployed to https://pr-2205.aam-digital.net/

@sleidig sleidig requested a review from tomwwinter January 29, 2024 17:14
Copy link
Collaborator

@TheSlimvReal TheSlimvReal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works very well. Also the filtering when clicking on the button at the side of each entry works, but only if the filter is available in the list component (in this case children filter on notes manager). But I think that problem might be fixed once we make the filters more self-configurable?

@sleidig sleidig merged commit c861126 into master Feb 1, 2024
7 checks passed
@sleidig sleidig deleted the count-by-entity branch February 1, 2024 19:05
@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.31.1-master.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released on @master managed by CI (semantic-release) label Feb 1, 2024
@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.31.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released managed by CI (semantic-release) label Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released on @master managed by CI (semantic-release) released managed by CI (semantic-release)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EntityCount Dashboard should display human-readable categories when disaggregating by a referenced entity
3 participants