Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added clear and select-all button #2245

Merged
merged 7 commits into from
Mar 7, 2024
Merged

Added clear and select-all button #2245

merged 7 commits into from
Mar 7, 2024

Conversation

sadaf895
Copy link
Contributor

@sadaf895 sadaf895 commented Feb 19, 2024

closes: #2222

Copy link
Contributor

Deployed to https://pr-2245.aam-digital.net/

Copy link
Member

@sleidig sleidig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well and has nice, simple code 👍

The UI looks a bit bulky still ...
I would try using a "flat" button (wihtout the borders the interface would probably be calmer) and letting them fill the whole width. Maybe also experiment with making the font-size a little smaller and/or adding color="accent" and check if that would look good (to make a bigger visual difference of the buttons with the actual options below)

@sadaf895
Copy link
Contributor Author

I have given some style to the buttons...Is it looking good or any specific modification required or you want to give any suggestion?

@sleidig sleidig marked this pull request as ready for review March 7, 2024 17:47
@sleidig sleidig merged commit a2d833e into master Mar 7, 2024
5 of 7 checks passed
@sleidig sleidig deleted the Filter_Dropdown_List branch March 7, 2024 18:10
@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.32.4-master.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released on @master managed by CI (semantic-release) label Mar 7, 2024
@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.33.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released managed by CI (semantic-release) label Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released on @master managed by CI (semantic-release) released managed by CI (semantic-release)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multi-status filter dropdown should offer "select all" / "select none"
3 participants