Export entity references both as id and as human-readable toString #2295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deployed to https://pr-2295.aam-digital.net/ |
…g_for_entities_in_download_service
…g_for_entities_in_download_service
sleidig
reviewed
Apr 12, 2024
| if (columnLabels.has(key + "_readable")) { | ||
| const relatedEntitiesIds: string[] = Array.isArray(item[key]) | ||
| ? item[key] | ||
| : item[key].split(); |
There was a problem hiding this comment.
The item[key].split() was meant to build an array containing the string as single value. But [item[key]] is simpler and shorter.
sleidig
approved these changes
Apr 12, 2024
sleidig
deleted the
also_export_toString_for_entities_in_download_service
branch
|
🎉 This PR is included in version 3.35.0-master.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 3.35.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #2151