Dialog & Routed Views #2304
Merged
Dialog & Routed Views #2304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for clarity and future developments
|
Deployed to https://pr-2304.aam-digital.net/ |
…note-details and others
sleidig
commented
Mar 27, 2024
src/app/child-dev-project/notes/notes-manager/notes-manager.component.html
Outdated
Show resolved
Hide resolved
# Conflicts: # src/app/core/admin/admin-entity/admin-entity.component.spec.ts
for clarity and future developments
# Conflicts: # src/app/core/config/config-fix.ts # src/app/core/entity-details/entity-details/entity-details.component.ts # src/app/core/entity-list/entity-list/entity-list.component.spec.ts # src/app/core/entity-list/entity-list/entity-list.component.ts
for clarity and future developments
sleidig
force-pushed
the
refactor/config-entitytype
branch
from
78473f7 to
a326549
Compare
… view-architecture # Conflicts: # src/app/core/config/config-fix.ts # src/app/core/entity-details/entity-details/entity-details.component.ts # src/app/core/entity-list/entity-list/entity-list.component.spec.ts # src/app/core/entity-list/entity-list/entity-list.component.ts
# Conflicts: # src/app/core/config/config-fix.ts # src/app/core/entity-details/entity-details/entity-details.component.ts # src/app/core/entity-list/entity-list/entity-list.component.spec.ts # src/app/core/entity-list/entity-list/entity-list.component.ts
|
🎉 This PR is included in version 3.35.0-master.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 3.35.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #2069
objectives:
changes implemented:
appConfig:note-detailsto a standardview:note/:idapp-view-title,app-dialog-buttons)AbstractEntityDetailsComponentto be reusedDialogViewComponentsimilar to RoutedViewComponentpass entity refs to routed details instead of loading it itself there(turns out to be difficult to pass custom data through router)problems to be fixed:
manually migrate appConfig:note-details to view:note/:id