-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added drag functionality in admin tabs #2305
Conversation
Deployed to https://pr-2305.aam-digital.net/ |
… enhancements/draggable-tabs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works fairly well :-)
-
Also, the drop preview (how the element is displayed during dragging, while not lifting the mouse yet) is showing the moved element on top of the next one rather than to the side, but I am not sure how difficult this is to fix as all of that is in the mat-tab layouts.
-
when I drag the currently active tab, after dropping it suddenly another (the new first tab) is selected. The selected tab should ideally remain active
A thought about usability overall, now that I see it in action: What do you think about only making the current active tab draggable (with the handle next to the title form field)? Then there would be a bit less complexity in the UI overall, with less drag handles
src/app/core/admin/building-blocks/admin-tabs/admin-tabs.component.ts
Outdated
Show resolved
Hide resolved
🎉 This PR is included in version 3.34.2-master.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 3.34.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
closes: #2269
Visible/Frontend Changes
Description of changes