Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2120 / Setup Wizard: Configure static entity details like label and icon #2328

Merged
merged 21 commits into from
Apr 5, 2024
Merged

#2120 / Setup Wizard: Configure static entity details like label and icon #2328

merged 21 commits into from
Apr 5, 2024

Conversation

Abhinegi2
Copy link
Contributor

@Abhinegi2 Abhinegi2 commented Apr 1, 2024 •
edited
Loading

closes: #2120

Visible/Frontend Changes

  • Added a new form to edit the static details of entity types.
  • This form will be accessible by the General setting tab.
  • Update the save functionality in AdminEntityComponnet to save static details of the entity type.
  • Added trim split and trim method for tostringAttribute.

@Abhinegi2 Abhinegi2 self-assigned this Apr 1, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 1, 2024

Deployed to https://pr-2328.aam-digital.net/

@Abhinegi2 Abhinegi2 changed the title added edit entity type component #2120 / Setup Wizard: Configure static entity details like label and icon Apr 2, 2024
sleidig
sleidig reviewed Apr 3, 2024
View reviewed changes
src/app/core/admin/admin-entity/admin-entity-edit/admin-entity-edit.component.html Outdated
Comment on lines 43 to 47
<input
formControlName="icon"
matInput
[placeholder]="formLabel.value"
/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check out whether we can use a component to visually select fontawesome icons.
Maybe the following or any other that you might find: https://www.npmjs.com/package/ngx-icon-picker

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion. However, I've looked into it, and unfortunately, ngx-icon-picker doesn't support Angular 17, and I'm currently unable to find another library that does.

@Abhinegi2 Abhinegi2 marked this pull request as ready for review April 3, 2024 10:43
sleidig
sleidig requested changes Apr 3, 2024
View reviewed changes
Copy link
Member

@sleidig sleidig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did some small code cleanups.

One functional problem I still discovered:
When you switch between General Settings and Details section, the changes in general form are lost. These have to be kept until you save or cancel the admin view overall.

@Abhinegi2
Copy link
Contributor Author

Did some small code cleanups.

One functional problem I still discovered: When you switch between General Settings and Details section, the changes in general form are lost. These have to be kept until you save or cancel the admin view overall.

This issue is fixed now! can you please let me know now if it's working as expected or do you have any suggestion?

sleidig
sleidig approved these changes Apr 5, 2024
View reviewed changes
Copy link
Member

@sleidig sleidig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work 👍

@sleidig sleidig merged commit e2f0945 into master Apr 5, 2024
4 of 6 checks passed
@sleidig sleidig deleted the feature/entity-type-configurable branch April 5, 2024 08:49
@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.35.0-master.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released on @master managed by CI (semantic-release) label Apr 8, 2024
@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.35.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released managed by CI (semantic-release) label Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sleidig sleidig sleidig approved these changes

Assignees

@Abhinegi2 Abhinegi2

Labels
released on @master managed by CI (semantic-release) released managed by CI (semantic-release)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setup Wizard: Configure static entity details like label and icon
3 participants
@Abhinegi2 @aam-digital-ci @sleidig