Added multi select reorder functionality #2334
Conversation
|
Deployed to https://pr-2334.aam-digital.net/ |
…tps://github.com/Aam-Digital/ndb-core into feature/enable-multiselect-for-tostringattribute
There was a problem hiding this comment.
Looks quite good already 🙂
From functional / UI testing:
- dropdown items checkbox and text should be vertically aligned:
- should only allow string or number fields currently. Other types (schemaField.dataType) will not be displayed properly if used as "toStringAttributes
.../admin/admin-entity/admin-entity-general-settings/admin-entity-general-settings.component.ts
Outdated
Show resolved
Hide resolved
src/app/core/common-components/basic-autocomplete/basic-autocomplete.component.html
Outdated
Show resolved
Hide resolved
| @@ -101,6 +107,8 @@ export class BasicAutocompleteComponent<O, V = O> | |||
| * Whether the user should be able to select multiple values. | |||
| */ | |||
| @Input() multi?: boolean; | |||
| @Input() reorder?: boolean; | |||
| autocompleteDraggableOptions: SelectableOption<O, V>[] = []; | |||
There was a problem hiding this comment.
can we not use the same autocompleteSuggestedOptions array also if drag&drop is availalbe?
There was a problem hiding this comment.
The drop method expects an array as input to perform operations such as moving items within the array. However, autocompleteSuggestedOptions is an Observable that emits values asynchronously, and it's not directly usable as an array in the drop method. That is why I am using different arrays to drag and drop.
Hi @sleidig I have fixed this. Does this look fine or do we need some more modifications here? |
…tps://github.com/Aam-Digital/ndb-core into feature/enable-multiselect-for-tostringattribute
Abhinegi2
changed the title
There was a problem hiding this comment.
UI looks good now. Did some minor code cleanup.
One issue I still discovered: After switching tab and coming back (i.e. re-initializing the options), the order in the form field is still correct but in the dropdown it is back to original order not matching the reordered sorting anymore.
I would suggest to put all selected items at the top of the dropdown, in the order they are selected. And then drop all the remaining fields in their default order.
I have updated the functionality a little bit. Can you please check now that it's looking fine or do you have any suggestions? |
|
🎉 This PR is included in version 3.35.0-master.5 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 3.35.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
closes: #2120
Visible/Frontend Changes