Setup Wizard: Configure Validators for fields #2345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deployed to https://pr-2345.aam-digital.net/ |
… feature/add-validator-for-entity-field
Abhinegi2
changed the title
Abhinegi2
changed the title
sleidig
requested changes
Apr 18, 2024
src/app/core/admin/admin-entity-details/admin-entity-field/admin-entity-field.component.html
Outdated
Show resolved
Hide resolved
src/app/core/admin/admin-entity-details/admin-entity-field/admin-entity-field.component.html
Outdated
Show resolved
Hide resolved
...ntity-field/configure-entity-field-validator/configure-entity-field-validator.component.scss
Outdated
Show resolved
Hide resolved
...-entity-field/configure-entity-field-validator/configure-entity-field-validator.component.ts
Outdated
Show resolved
Hide resolved
...-entity-field/configure-entity-field-validator/configure-entity-field-validator.component.ts
Outdated
Show resolved
Hide resolved
...ntity-field/configure-entity-field-validator/configure-entity-field-validator.component.html
Outdated
Show resolved
Hide resolved
...ntity-field/configure-entity-field-validator/configure-entity-field-validator.component.html
Outdated
Show resolved
Hide resolved
...ntity-field/configure-entity-field-validator/configure-entity-field-validator.component.html
Outdated
Show resolved
Hide resolved
|
@sleidig did requested changes can you please check now? |
sleidig
requested changes
Apr 23, 2024
...-entity-field/configure-entity-field-validator/configure-entity-field-validator.component.ts
Outdated
Show resolved
Hide resolved
...-entity-field/configure-entity-field-validator/configure-entity-field-validator.component.ts
Outdated
Show resolved
Hide resolved
sleidig
reviewed
Apr 23, 2024
...ntity-field/configure-entity-field-validator/configure-entity-field-validator.component.html
Outdated
Show resolved
Hide resolved
sleidig
force-pushed
the
feature/add-validator-for-entity-field
branch
from
dda1965 to
0f6133a
Compare
…ub.com/Aam-Digital/ndb-core into feature/add-validator-for-entity-field
|
@sleidig did the requested changes, please have a look now. |
sleidig
approved these changes
Apr 23, 2024
sleidig
reviewed
Apr 23, 2024
...ty-field/configure-entity-field-validator/configure-entity-field-validator.component.spec.ts
Outdated
Show resolved
Hide resolved
…figure-entity-field-validator/configure-entity-field-validator.component.spec.ts
|
🎉 This PR is included in version 3.35.0-master.10 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 3.35.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #2118
Visible/Frontend Changes