Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added shift and select all logic to Bulk Actions #2451

Merged
merged 22 commits into from
Aug 26, 2024

Conversation

Abhinegi2
Copy link
Contributor

@Abhinegi2 Abhinegi2 commented Jul 8, 2024

closes: #2290

Visible/Frontend Changes

  • Add checkbox buttons to "select all" and "clear" the full list (all pages but only the currently filtered rows)
  • Added the common approach to hold the "shift" key to select a range of rows between the start and end item.

@Abhinegi2 Abhinegi2 self-assigned this Jul 8, 2024
Copy link
Contributor

github-actions bot commented Jul 8, 2024

Deployed to https://pr-2451.aam-digital.net/

@Abhinegi2 Abhinegi2 changed the title added shift logic and select all logic Added shift and select all logic to Bulk Actions Jul 10, 2024
@Abhinegi2 Abhinegi2 marked this pull request as ready for review July 11, 2024 07:30
@Abhinegi2 Abhinegi2 requested a review from sleidig July 11, 2024 07:30
@tomwwinter tomwwinter self-requested a review July 11, 2024 12:34
@tomwwinter
Copy link
Contributor

I found an issue when selecting single elements:

Screen.Recording.2024-07-11.at.14.51.58.mov

@Abhinegi2
Copy link
Contributor Author

I found an issue when selecting single elements:

Screen.Recording.2024-07-11.at.14.51.58.mov

let me check and fix this, will update you once done

@Abhinegi2
Copy link
Contributor Author

@tomwwinter it's fixed can you please check now?

@tomwwinter
Copy link
Contributor

Looks better now. I just saw some CSS glitches, when the bulk overlay is visible:

image image

Maybe we can add some white background here?

Copy link
Contributor

@tomwwinter tomwwinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Abhinegi2
Copy link
Contributor Author

Looks better now. I just saw some CSS glitches, when the bulk overlay is visible:

image image
Maybe we can add some white background here?

@tomwwinter just found that bulk action UI is not properly working for small screens(bulk actions are visible two times). I am also attaching an image for reference, we can create a new ticket/issue for the overall UI fixes -
image

@Abhinegi2 Abhinegi2 requested a review from tomwwinter August 13, 2024 08:54
Copy link
Contributor

@tomwwinter tomwwinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I did some refactoring with @sleidig to solve some very tricky bugs with the templating logic.

@sleidig sleidig merged commit 831cb09 into master Aug 26, 2024
9 of 12 checks passed
@sleidig sleidig deleted the feat/bulk-action-by-using-shift-key branch August 26, 2024 16:32
@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.41.0-master.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released on @master managed by CI (semantic-release) label Aug 26, 2024
@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.41.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released managed by CI (semantic-release) label Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released on @master managed by CI (semantic-release) released managed by CI (semantic-release)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bulk actions should allow to select range of rows by holding "shift" key
4 participants