-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added shift and select all logic to Bulk Actions #2451
Conversation
Deployed to https://pr-2451.aam-digital.net/ |
I found an issue when selecting single elements: Screen.Recording.2024-07-11.at.14.51.58.mov |
let me check and fix this, will update you once done |
@tomwwinter it's fixed can you please check now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@tomwwinter just found that bulk action UI is not properly working for small screens(bulk actions are visible two times). I am also attaching an image for reference, we can create a new ticket/issue for the overall UI fixes - |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I did some refactoring with @sleidig to solve some very tricky bugs with the templating logic.
🎉 This PR is included in version 3.41.0-master.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 3.41.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
closes: #2290
Visible/Frontend Changes