Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent re-sync after reloading the page if user related permission is set #2665

Merged
merged 5 commits into from
Nov 25, 2024
Merged

fix: prevent re-sync after reloading the page if user related permission is set #2665

merged 5 commits into from
Nov 25, 2024

Conversation

tomwwinter
Copy link
Contributor

closes: #2542

@github-actions GitHub Actions
Copy link

Deployed to https://pr-2665.aam-digital.net/

sleidig
sleidig requested changes Nov 15, 2024
View reviewed changes
Copy link
Member

@sleidig sleidig left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works to resolve the resync bug (although I don't completely understand yet what exactly happened causing it ...)

However, users without a profile entity linked (i.e. no "exact_username" attribute in keycloak; which we do officially support) do not get any access now, even with a role that provides "manage all" without project-based rules.

We should have unit tests for this central functionality of project-based permissions. Not sure how to write those ... if in doubt, let's do this together in a pair programming session.

src/app/core/permissions/ability/ability.service.ts Outdated Show resolved Hide resolved
@sleidig sleidig merged commit 7115646 into master Nov 25, 2024
6 of 8 checks passed
@sleidig sleidig deleted the tw/fix/2542-permissions-rules-cause-re-sync branch November 25, 2024 15:04
@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.43.0-master.8 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released on @master managed by CI (semantic-release) label Nov 25, 2024
@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.43.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released managed by CI (semantic-release) label Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sleidig sleidig sleidig approved these changes

Assignees
No one assigned
Labels
released on @master managed by CI (semantic-release) released managed by CI (semantic-release)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some permission rules can cause re-sync after every reload of the app
3 participants
@tomwwinter @aam-digital-ci @sleidig