Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the bug edit location dialog save button not reachable on mobile #2666

Merged
merged 6 commits into from
Nov 18, 2024

Conversation

sadaf895
Copy link
Contributor

closes: #2655

Copy link

Deployed to https://pr-2666.aam-digital.net/

Copy link
Member

@sleidig sleidig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The save button is always accessible now 👍

However, the map part is so big that even on large screens we have scroll bars now. This should be limited so that it only fills the dialog window but doesn't need scrolling (at least for large windows)

image

@sleidig sleidig merged commit 16580a7 into master Nov 18, 2024
13 checks passed
@sleidig sleidig deleted the issue_#2655 branch November 18, 2024 15:59
@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.43.0-master.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released on @master managed by CI (semantic-release) label Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released on @master managed by CI (semantic-release)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edit location dialog save button not reachable on mobile
3 participants