Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import UI auto-mapped columns cannot be cleared/reset #2846

Merged
merged 33 commits into from
Feb 18, 2025
Merged

Import UI auto-mapped columns cannot be cleared/reset #2846

merged 33 commits into from
Feb 18, 2025

Conversation

Abhinegi2
Copy link
Contributor

@Abhinegi2 Abhinegi2 commented Feb 11, 2025 •
edited
Loading

closes: #2782

Visible/Frontend Changes

  • Now the child component focuses on rendering a single column mapping.

@Abhinegi2 Abhinegi2 self-assigned this Feb 11, 2025
@github-actions GitHub Actions
Copy link
Contributor

Deployed to https://pr-2846.aam-digital.net/

@Abhinegi2 Abhinegi2 requested a review from sleidig February 11, 2025 09:22
@Abhinegi2 Abhinegi2 marked this pull request as ready for review February 12, 2025 10:19
@Abhinegi2 Abhinegi2 requested review from sleidig and removed request for sleidig February 12, 2025 10:20
sleidig
sleidig requested changes Feb 12, 2025
View reviewed changes
Copy link
Member

@sleidig sleidig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small code cleanup suggestions still 🙂

@sleidig
Copy link
Member

sleidig commented Feb 13, 2025

@Abhinegi2 I still found one functional bug:

  1. download a csv from Children list as sample to re-import
  2. Import that file as Children
  3. In "Map Columns" step, switch the "gender" column directly to map to field "Center" (instead of emptying the field)
  4. open the "Configure value mapping" dialog
  5. --> it still shows the mapping details related to gender rather then "center"

Abhinegi2 and others added 2 commits February 14, 2025 10:45
@Abhinegi2 @sleidig
Update src/app/core/import/edit-import-column-mapping/edit-import-col…
34ea9db 
…umn-mapping.component.ts

Co-authored-by: Sebastian <sebastian@aam-digital.com>
@Abhinegi2 @sleidig
Update src/app/core/import/edit-import-column-mapping/edit-import-col…
f67700f 
…umn-mapping.component.ts

Co-authored-by: Sebastian <sebastian@aam-digital.com>
@sleidig
Copy link
Member

sleidig commented Feb 18, 2025

Unfortunately there still seem to be issues in the preview stage, @Abhinegi2 : Mappings are not done on the newly selected details (column title here should be "center" and values should be valid):
image

sleidig
sleidig approved these changes Feb 18, 2025
View reviewed changes
Copy link
Member

@sleidig sleidig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well now and is clean code. Thanks, @Abhinegi2 👍

@sleidig sleidig merged commit d5316ea into master Feb 18, 2025
13 checks passed
@sleidig sleidig deleted the refactor/import-mapping-component branch February 18, 2025 15:53
@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.46.3-master.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released on @master managed by CI (semantic-release) label Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sleidig sleidig sleidig approved these changes

Assignees

@Abhinegi2 Abhinegi2

Labels
released on @master managed by CI (semantic-release)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Import UI auto-mapped columns cannot be cleared/reset
3 participants
@Abhinegi2 @sleidig @aam-digital-ci