Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix entity select #880

Merged
merged 9 commits into from
Jul 7, 2021
Merged

Fix entity select #880

merged 9 commits into from
Jul 7, 2021

Conversation

TheSlimvReal
Copy link
Collaborator

see issue: #872

Visible/Frontend Changes

  • Unselected entities are visible in the dropdown

Architectural/Backend Changes

--

@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2021

Deployed to https://test-deployment-pr-880.herokuapp.com/

sleidig
sleidig approved these changes Jul 7, 2021
View reviewed changes
Copy link
Member

@sleidig sleidig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works and looks good 👍

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 7, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sleidig sleidig merged commit 44e661d into master Jul 7, 2021
@sleidig sleidig deleted the fix-entity-select branch July 7, 2021 17:34
aam-digital-ci pushed a commit that referenced this pull request Jul 7, 2021
@semantic-release-bot
chore(release): 2.52.3
066e6dd 
## [2.52.3](2.52.2...2.52.3) (2021-07-07)

### Bug Fixes

* entity select field shows removed entries in dropdown again immediately ([#880](#880)) ([44e661d](44e661d)), closes [#872](#872)
@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 2.52.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sleidig sleidig sleidig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TheSlimvReal @aam-digital-ci @sleidig