Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor FormDialogService and EntitySubrecordComponent.showEntityInForm to avoid duplication #921

Closed
sleidig opened this issue Jul 30, 2021 · 3 comments
Closed

Refactor FormDialogService and EntitySubrecordComponent.showEntityInForm to avoid duplication #921

sleidig opened this issue Jul 30, 2021 · 3 comments
Labels
Type: Refactoring / Technical Enh. Technical Enhancement without changes for the user

Comments

@sleidig
Copy link
Member

sleidig commented Jul 30, 2021 •
edited
Loading

The FormDialogService is currently handling similar logic to the EnittySubrecordComponen.showEntityInForm() which directly uses MatDialog. This probably needs a refactoring to avoid complex and similar code.

  • we should avoid duplication of similar logic for opening popups and saving results
  • we should probably have one central base service to open any dialog, in order to give it similar look and feel (e.g. setting maxHeight to ensure scrollbars are available if necessary)
  • merge RowDetailsComponent and EntityFormComponent (see TodosModule work)
@sleidig sleidig added Type: Refactoring / Technical Enh. Technical Enhancement without changes for the user discuss labels Jul 30, 2021
@sleidig
Copy link
Member Author

sleidig commented Jul 30, 2021 •
edited
Loading

@TheSlimvReal , see PR #922

@Schottkyc137 Schottkyc137 self-assigned this Feb 2, 2022
@sleidig sleidig moved this to Triage in All Tasks & Issues Feb 8, 2022
@sleidig sleidig moved this from Triage to In Progress in All Tasks & Issues Feb 8, 2022
@sleidig sleidig moved this to In Progress in Important Fixes & Enhancements Feb 8, 2022
@sleidig sleidig moved this from In Progress to Todo in All Tasks & Issues Jun 2, 2022
@sleidig sleidig moved this from In Progress to Todo in Important Fixes & Enhancements Jul 18, 2022
@sleidig sleidig mentioned this issue Dec 20, 2022
Merged
15 tasks
@sleidig
Copy link
Member Author

sleidig commented Dec 20, 2022

this may also include merging RowDetails and EntityForm or at least getting to a more clear reuse for them: #1578 (comment)

@sleidig sleidig mentioned this issue Dec 21, 2022
Open
@TheSlimvReal
Copy link
Collaborator

Initial issue doesn't seem to be relevant anymore as entity subrecord is already using the FormDialogService

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Refactoring / Technical Enh. Technical Enhancement without changes for the user
Projects
No open projects
Important Fixes & Enhancements
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sleidig @TheSlimvReal @Schottkyc137