Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: log calculated metric with SplitTrainer #364

Merged
merged 4 commits into from
Nov 7, 2023
Merged

feat: log calculated metric with SplitTrainer #364

merged 4 commits into from
Nov 7, 2023

Conversation

MartinBernstorff
Copy link
Contributor

  • misc.
  • feat: log calculated metric

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 6, 2023

Looks like your PR modifies shared library files in psycop/common/.

We highly recommend getting your code reviewed by one of the core maintainers to avoid breaking other projects that depend on these files :-)

HLasse
HLasse approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@HLasse HLasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Can we add a logger.info method though?

@MartinBernstorff MartinBernstorff enabled auto-merge (squash) November 7, 2023 09:41
@MartinBernstorff MartinBernstorff merged commit 9759f7c into main Nov 7, 2023
5 checks passed
@MartinBernstorff MartinBernstorff deleted the 23_11_06_15_mylpl branch November 7, 2023 09:45
MartinBernstorff added a commit that referenced this pull request Nov 7, 2023
@MartinBernstorff
feat: log calculated metric with SplitTrainer (#364)
36747d9 
- misc.
- feat: log calculated metric
MartinBernstorff added a commit that referenced this pull request Nov 7, 2023
@MartinBernstorff
Squashed commit of the following:
68b359d 
commit fd252a1
Author: github-actions <github-actions@github.com>
Date:   Tue Nov 7 09:53:59 2023 +0000

    0.131.0

    Automatically generated by python-semantic-release

commit 0b59e91
Author: Martin Bernstorff <martinbernstorff@gmail.com>
Date:   Tue Nov 7 10:53:06 2023 +0100

    feat: add logger.info() (#382)

    - Squash changes from parent branch
    - feat: add logger.info

commit 1d96715
Author: github-actions <github-actions@github.com>
Date:   Tue Nov 7 09:46:33 2023 +0000

    0.130.0

    Automatically generated by python-semantic-release

commit 9759f7c
Author: Martin Bernstorff <martinbernstorff@gmail.com>
Date:   Tue Nov 7 10:45:22 2023 +0100

    feat: log calculated metric with SplitTrainer (#364)

    - misc.
    - feat: log calculated metric

commit 777ccdd
Author: Martin Bernstorff <martinbernstorff@gmail.com>
Date:   Mon Nov 6 19:14:46 2023 +0100

    ci: only push dev container for tests (#377)

    - Squash changes from parent branch
    - ci: do not publish dev container
    - ci: push test dev container on push to main

commit e1ba8ce
Author: Martin Bernstorff <martinbernstorff@gmail.com>
Date:   Mon Nov 6 19:13:22 2023 +0100

    dev: do not pre-compile pip-installed packages (#376)

commit 5b3c2a6
Author: Martin Bernstorff <martinbernstorff@gmail.com>
Date:   Mon Nov 6 18:37:05 2023 +0100

    dev: use docker buildkit cache for pip (#374)

    This saves pip's cache so it can be used across rebuilds, dramatically
    improving performance on rebuild 👍

commit 70100be
Author: Martin Bernstorff <martinbernstorff@gmail.com>
Date:   Mon Nov 6 18:18:18 2023 +0100

    dev: use docker cache when pip installing (#373)

commit 0615eb1
Author: Martin Bernstorff <martinbernstorff@gmail.com>
Date:   Mon Nov 6 17:02:03 2023 +0000

    ci: misc

commit 82d00d8
Author: Martin Bernstorff <martinbernstorff@gmail.com>
Date:   Mon Nov 6 17:29:32 2023 +0100

    ci: free space on runner (#372)

commit 572debd
Author: Martin Bernstorff <martinbernstorff@gmail.com>
Date:   Mon Nov 6 17:14:43 2023 +0100

    ci: update devcontainer publish workflow name (#371)

commit 45e6e09
Author: Martin Bernstorff <martinbernstorff@gmail.com>
Date:   Mon Nov 6 17:12:45 2023 +0100

    ci: remove conditional setup for multi-architecture builds (#370)

commit dd1ef65
Author: Martin Bernstorff <martinbernstorff@gmail.com>
Date:   Mon Nov 6 17:01:23 2023 +0100

    ci: conditional multi-architecture build support for (#369)

commit 69d06f9
Author: Martin Bernstorff <martinbernstorff@gmail.com>
Date:   Mon Nov 6 16:54:39 2023 +0100

    ci: use cache when publishing dev container (#368)

commit 142a811
Author: Martin Bernstorff <martinbernstorff@gmail.com>
Date:   Mon Nov 6 16:49:37 2023 +0100

    ci: do not require non-concurrency (#367)

    * ci: run separate jobs for each docker platform

    * ci: do not require non-concurrency

    Makes it easier to parse which commits have failed or succeeded in the mainline history.

commit 371e843
Author: Martin Bernstorff <martinbernstorff@gmail.com>
Date:   Mon Nov 6 16:41:00 2023 +0100

    ci: run separate jobs for each docker platform (#366)

commit 562eb85
Author: Martin Bernstorff <martinbernstorff@gmail.com>
Date:   Mon Nov 6 16:39:05 2023 +0100

    ci: do not stop docker builds based on concurrency (#362)

    * Squash changes from parent branch

    * ci: allow push to cache on main

    * ci: build devcontainer for arm on push to main

    * misc.

    * ci: do not stop docker builds on concurrency

commit 241368e
Author: Martin Bernstorff <martinbernstorff@gmail.com>
Date:   Mon Nov 6 16:06:31 2023 +0100

    ci: push arm devcontainer on main (#361)

    * Squash changes from parent branch

    * ci: allow push to cache on main

    * ci: build devcontainer for arm on push to main

    * misc.

commit 9119fd6
Author: Martin Bernstorff <martinbernstorff@gmail.com>
Date:   Mon Nov 6 15:54:14 2023 +0100

    ci: run tests on PRs if not merging into main (#360)

    * ci: run tests on PRs if not merging into main

    * ci: misc.

    * misc.

commit c39beaf
Author: Martin Bernstorff <martinbernstorff@gmail.com>
Date:   Mon Nov 6 14:38:35 2023 +0100

    dev: skip tests only failing on arm-docker if on arm-docker (#359)

    * Squash changes from parent branch

    * refactor: cleaner tests

commit fdc0a4e
Author: github-actions <github-actions@github.com>
Date:   Mon Nov 6 13:16:52 2023 +0000

    0.129.1

    Automatically generated by python-semantic-release

commit 792c5d9
Merge: 9506ed5 4f93dc1
Author: Lasse Hansen <lasseh0310@gmail.com>
Date:   Mon Nov 6 14:15:59 2023 +0100

    Merge pull request #349 from Aarhus-Psychiatry-Research/binary-classification-pipeline

    implemented binary classification pipeline
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HLasse HLasse HLasse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MartinBernstorff @HLasse