-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for mlflow experiment tracker #432
feat: add support for mlflow experiment tracker #432
Conversation
…for-mlflow-experiment-tracker
Looks like your PR modifies shared library files in We highly recommend getting your code reviewed by one of the core maintainers to avoid breaking other projects that depend on these files :-) |
This PR is stale because it has been open 1+ days with no activity. Feel free to either 1) remove the stale label or 2) comment. If nothing happens, this will be closed in 7 days. |
Will look at this next week. |
…for-mlflow-experiment-tracker
…for-mlflow-experiment-tracker
A security vulnerability was identified in MLFlow, hindering this merge. Vuln 1: https://security.snyk.io/vuln/SNYK-PYTHON-MLFLOW-6069186 Report: https://huntr.com/bounties/7cf918b5-43f4-48c0-a371-4d963ce69b30/ |
These would not be an issue for us, since we are not hosting the MLFlow server ourselves. I'll give it a couple of days, but if no fix is committed soon, we might want to apply for an exception with Søren/Andreas. |
2.9 is being released this week. If it succeeds, we're ready to merge: mlflow/mlflow#10533 |
…for-mlflow-experiment-tracker
En yderligere: https://security.snyk.io/vuln/SNYK-PYTHON-MLFLOW-6069159 HVIS man bruger MLFLow som server eller UI (det gør vi ikke, det er BI der står for det) Fordi det er BI der hoster MLFlow serveren er det ikke en sikkerhedssvaghed for os, da alle med adgang til MLFlow serveren også har adgang til vores server og data. Den potentielle svaghed er større, så vil gerne snakke om den :-) |
2358060
to
000adb8
Compare
This PR is stale because it has been open 1+ days with no activity. Feel free to either 1) remove the stale label or 2) comment. If nothing happens, this will be closed in 7 days. |
Afventer svar på undtagelse fra Andreas. EDIT: Godkendt! |
…for-mlflow-experiment-tracker
Fixes #315.
@HLasse Hold off on review, a new security vuln has been identified since I last looked at it.