Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for mlflow experiment tracker #432

Merged

Conversation

MartinBernstorff
Copy link
Contributor

@MartinBernstorff MartinBernstorff commented Nov 14, 2023

Fixes #315.

@HLasse Hold off on review, a new security vuln has been identified since I last looked at it.

Copy link
Contributor

github-actions bot commented Nov 14, 2023

Looks like your PR modifies shared library files in psycop/common/.

We highly recommend getting your code reviewed by one of the core maintainers to avoid breaking other projects that depend on these files :-)

Copy link
Contributor

This PR is stale because it has been open 1+ days with no activity. Feel free to either 1) remove the stale label or 2) comment. If nothing happens, this will be closed in 7 days.

@MartinBernstorff
Copy link
Contributor Author

Will look at this next week.

@MartinBernstorff
Copy link
Contributor Author

MartinBernstorff commented Nov 30, 2023

@MartinBernstorff
Copy link
Contributor Author

These would not be an issue for us, since we are not hosting the MLFlow server ourselves. I'll give it a couple of days, but if no fix is committed soon, we might want to apply for an exception with Søren/Andreas.

@MartinBernstorff
Copy link
Contributor Author

2.9 is being released this week. If it succeeds, we're ready to merge: mlflow/mlflow#10533

@MartinBernstorff
Copy link
Contributor Author

En yderligere: https://security.snyk.io/vuln/SNYK-PYTHON-MLFLOW-6069159
Detaljeret forklaring her: https://huntr.com/bounties/3e64df69-ddc2-463e-9809-d07c24dc1de4/

HVIS man bruger MLFLow som server eller UI (det gør vi ikke, det er BI der står for det)
OG en bruger på samme netværk (Region Midt) forsøger at oprette en bruger via en HTTP request
SÅ kan de tilgå filer der ligger på MLFlow serveren

Fordi det er BI der hoster MLFlow serveren er det ikke en sikkerhedssvaghed for os, da alle med adgang til MLFlow serveren også har adgang til vores server og data. Den potentielle svaghed er større, så vil gerne snakke om den :-)

@MartinBernstorff MartinBernstorff force-pushed the 315-feat-add-support-for-mlflow-experiment-tracker branch from 2358060 to 000adb8 Compare December 7, 2023 12:43
Copy link
Contributor

This PR is stale because it has been open 1+ days with no activity. Feel free to either 1) remove the stale label or 2) comment. If nothing happens, this will be closed in 7 days.

@MartinBernstorff
Copy link
Contributor Author

MartinBernstorff commented Dec 12, 2023

Afventer svar på undtagelse fra Andreas.

EDIT: Godkendt!

@MartinBernstorff MartinBernstorff merged commit 9922000 into main Dec 14, 2023
5 checks passed
@MartinBernstorff MartinBernstorff deleted the 315-feat-add-support-for-mlflow-experiment-tracker branch December 14, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add support for mlflow experiment tracker
2 participants