Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pretrain with mlflow #563

Merged
merged 26 commits into from
Dec 18, 2023
Merged

Conversation

MartinBernstorff
Copy link
Contributor

@MartinBernstorff MartinBernstorff commented Dec 15, 2023

For #560, I needed the path of the pretrained model. However, I think it is on your user account (ADMINKEN**) @KennethEnevoldsen.

So, wanted to run a new pretraining that saves to a dir on E:/shared_resources, and might as well add mlflow at the same time.

  • Unified logger interfaces, to make it easier to change between them
  • Added mlflow logger

Started a training, but failed because of the MLflow server being down. More info here: https://github.com/Aarhus-Psychiatry-Research/psycop-ml-ops/issues/54

Also fixes #562.

@MartinBernstorff MartinBernstorff linked an issue Dec 15, 2023 that may be closed by this pull request
Copy link
Contributor

Looks like your PR modifies shared library files in psycop/common/.

We highly recommend getting your code reviewed by one of the core maintainers to avoid breaking other projects that depend on these files :-)

@MartinBernstorff MartinBernstorff changed the title feat: try pretraining with mlflow feat: pretrain with mlflow Dec 15, 2023
@MartinBernstorff MartinBernstorff changed the title feat: pretrain with mlflow feat: pretrain with mlflow Dec 15, 2023
Copy link
Contributor

@KennethEnevoldsen KennethEnevoldsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let us discuss the factory - there is probably a good reason for it that I am missing.

psycop/common/sequence_models/logger.py Outdated Show resolved Hide resolved
psycop/common/sequence_models/train.py Outdated Show resolved Hide resolved
Copy link
Contributor

@KennethEnevoldsen KennethEnevoldsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@MartinBernstorff MartinBernstorff merged commit a0d21ba into main Dec 18, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: unify logger interfaces feat: setup pretraining with MLflow
2 participants