Add page-level key binding system (capture phase) #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement capture-phase input handling where pages intercept keys before focused components, enabling reliable navigation key handling (Escape, Tab). - Add PageKeyBindings class for registering page-level key handlers - Add HandlePageInput method to IBindablePage interface - Modify TerminaApplication.ProcessEvent() to call page handler first - Update ReactivePage to expose KeyBindings property - Update all gallery demo pages to use new KeyBindings pattern - Add comprehensive tests for page-level input handling Closes #104
Give Pages direct access to Navigate(), NavigateWithParams(), and Shutdown() methods instead of requiring wrapper methods on ViewModels. Framework changes: - Add WireUpNavigation() to IBindablePage interface - Add protected Navigate/NavigateWithParams/Shutdown methods to ReactivePage - Update TerminaApplication to wire up navigation to pages This is a cleaner framework design where: - Pages use Navigate() for input-driven navigation (Escape key, etc.) - ViewModels use Navigate() for business-logic-driven navigation Documentation updates: - Update input-handling.md with correct Page.Navigate() usage - Update architecture.md with two-phase input routing model - Update concepts index with new data flow diagram
ReactiveLayoutNode now properly subscribes to its child's Invalidated observable and propagates those events upward. This fixes the issue where animated nodes (like SpinnerNode) nested inside reactive layouts would not trigger redraws because their invalidation events were lost at the ReactiveLayoutNode boundary. Changes: - Added _childInvalidationSubscription field to track child subscriptions - Added SubscribeToChildInvalidation helper method - Subscribe to child invalidation when new child is set from observable - Re-subscribe on OnActivate to handle reactivation after navigation - Properly dispose child invalidation subscription in Dispose - Applied same fix to both ReactiveLayoutNode and ReactiveLayoutNode<T>
Register a page-level key binding for Spacebar that updates the spinner preview based on the currently highlighted item. This provides the same behavior as Enter for this single-select use case, making the UX more intuitive.
Highlight the scrollbar feature by renaming the column header and updating the description to show visible rows configuration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements capture-phase input handling where pages can intercept keyboard input before focused components receive it. This enables reliable navigation key handling (Escape, Tab) in gallery demos and other complex pages.
PageKeyBindingsclass for registering page-level key handlersHandlePageInputmethod toIBindablePageinterfaceTerminaApplication.ProcessEvent()to call page handler first (capture phase) before routing to focused components (bubble phase)ReactivePageto exposeKeyBindingspropertyTest plan
PageKeyBindingsclassCloses #104