Migrate all events to IObservable<T> for pure reactive architecture #50
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR establishes a consistent reactive-only pattern throughout Termina by migrating all .NET events to
IObservable<T>using System.Reactive Subjects.This is a breaking change - consumers using
+=event subscriptions must migrate to.Subscribe().Changes
Interface changes:
IInvalidatingNode.Invalidated:event Action?→IObservable<Unit>Layout nodes migrated:
TextInputNode:Submitted,TextChanged,Invalidated→ observablesSpinnerNode,ConditionalNode,ReactiveLayoutNode: useSubject<Unit>ScrollableContainerNode: migrated with proper subscription managementStreamingTextNode:ContentChangednow alias forInvalidatedobservableRendering classes migrated:
TextInput:OnSubmit→Submitted,OnDirty→DirtyScrollableContent:OnDirty→Dirty, now implementsIDisposableDocumentation & guidelines:
CLAUDE.mdestablishing architectural principle: no mixing System.Reactive with .NET eventsMigration Guide
Before:
After:
Test plan
Preparatory work for #43