chore: Explicitly list all enabled linters

Author: jimmidyson

.golangci.yml

@@ -1,12 +1,30 @@
-issues:
-  exclude-rules:
-    - path: pkg/kubefedctl/enable/enable.go
-      linters:
-        - unused
-        - structcheck
-    - path: pkg/kubefedctl/join.go
-      linters:
-        - structcheck
-    - path: pkg/kubefedctl/disable.go
-      linters:
-        - structcheck
+run:
+  timeout: 5m
+  skip-dirs:
+    - third-party
+
+linters:
+  disable-all: true
+  enable:
+  - deadcode
+  - errcheck
+  - goconst
+  - gocritic
+  - goimports
+  - gosimple
+  - govet
+  - ineffassign
+  - nolintlint
+  - prealloc
+  - staticcheck
+  - structcheck
+  - stylecheck
+  - typecheck
+  - unparam
+  - unused
+  - varcheck
+  - whitespace
+
+linters-settings:
+  goimports:
+    local-prefixes: sigs.k8s.io/kubefed

Makefile

@@ -67,7 +67,7 @@ TEST = $(TEST_CMD) $(TEST_PKGS)
 DOCKER_BUILD ?= $(DOCKER) run -it --rm -v $(DIR):$(BUILDMNT) -w $(BUILDMNT) $(BUILD_IMAGE) /bin/sh -c
 
 # TODO (irfanurrehman): can add local compile, and auto-generate targets also if needed
-.PHONY: all container push clean hyperfed controller kubefedctl test local-test vet fmt build bindir generate webhook e2e deploy.kind
+.PHONY: all container push clean hyperfed controller kubefedctl test local-test vet lint build bindir generate webhook e2e deploy.kind
 
 all: container hyperfed controller kubefedctl webhook e2e
 
@@ -80,8 +80,8 @@ build: hyperfed controller kubefedctl webhook
 vet:
 	go vet $(TEST_PKGS)
 
-fmt:
-	$(shell ./hack/update-gofmt.sh)
+lint:
+	golangci-lint run -c .golangci.yml --fix
 
 container: $(HYPERFED_TARGET)-linux-$(HOST_ARCH)
 	cp -f $(HYPERFED_TARGET)-linux-$(HOST_ARCH) images/kubefed/hyperfed

hack/go-tools/verify-gofmt.sh

@@ -60,7 +60,7 @@ curl "${curl_args}O" "${helm_url}" \
     && tar xzfp "${helm_tgz}" -C "${dest_dir}" --strip-components=1 "${platform}-amd64/helm" \
     && rm "${helm_tgz}"
 
-golint_version="1.27.0"
+golint_version="1.30.0"
 golint_dir="golangci-lint-${golint_version}-${platform}-amd64"
 golint_tgz="${golint_dir}.tar.gz"
 golint_url="https://github.com/golangci/golangci-lint/releases/download/v${golint_version}/${golint_tgz}"

hack/update-gofmt.sh

@@ -120,14 +120,12 @@ download-dependencies
 echo "Checking initial state of working tree"
 check-git-state
 
-echo "Verifying Gofmt"
-./hack/go-tools/verify-gofmt.sh
-
 echo "Checking boilerplate text"
 ./third-party/k8s.io/repo-infra/hack/verify_boilerplate.py --rootdir="${ROOT_DIR}"
 
 echo "Linting"
-golangci-lint run --timeout=5m
+golangci-lint run -c .golangci.yml --fix
+check-git-state
 
 echo "Checking that correct Error Package is used."
 ./hack/verify-errpkg.sh

scripts/download-binaries.sh

@@ -0,0 +1 @@
+checks = ["all"]