Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsing issues when using dimensions and colons in CSS #70

Open
FMeinicke opened this issue Jun 1, 2021 · 0 comments
Open

Parsing issues when using dimensions and colons in CSS #70

FMeinicke opened this issue Jun 1, 2021 · 0 comments

Comments

@FMeinicke
Copy link
Contributor

FMeinicke commented Jun 1, 2021

Hi, first of thanks for this cool plugin!

While playing around with it a little bit I noticed that some things don't seem to work as I expected:

  1. Using dimensions such as px or pt result in a syntax error when they're not inside double-quotes. I.e. font-size: 12px; does not work but font-size: "12px"; does. (Same for font: 12px serif; vs font: "12px serif";.)
  2. When a selector contains a : (colon) the parser also throws a syntax error.

My goal is to use the stylesheets we already have for our QWidget-based application (which heavily utilize Qt's QSS syntax, thus the requirement for having : and :: in the selectors) for QML as well. We just added a part to the application that provides a QML UI inside a QQuickWidget and we want to be able to style it just like we do it with widgets.

I would be totally happy if the parser simply wouldn't throw any errors for the two things I described. (I would love to create PR for that but I'm not familiar with the PEGlib at all, unfortunately.)

But do you think that pseudo-states like :hover or :enabled or even sub-controls could be implemented in the future as well? And generally speaking, is or was your plan at any point to support QSS or is this plugin just for vanilla CSS?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant