Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runPostProcessing could throw warning with no meaning #1443

Closed
Zejnilovic opened this issue Jul 13, 2020 · 1 comment · Fixed by #1392
Closed

runPostProcessing could throw warning with no meaning #1443

Zejnilovic opened this issue Jul 13, 2020 · 1 comment · Fixed by #1392
Assignees
@AdrianOlosutean
Labels
bug Something isn't working Conformance Conformance Job affected priority: low Nice to have Standardization Standardization Job affected UX Something concerning UX

Comments

@Zejnilovic
Copy link
Contributor

Describe the bug

runPostProcessing in CommonJobExecution can throw out a warning which is connected to a piece of code that could not even run in the end.

Expected behaviour

Have the log.warn in conditional, not running it if there's no reason to.

Additional context

Needs #1377 to be merged
@Zejnilovic Zejnilovic added bug Something isn't working Conformance Conformance Job affected Standardization Standardization Job affected UX Something concerning UX priority: low Nice to have labels Jul 13, 2020
@Zejnilovic Zejnilovic mentioned this issue Jul 13, 2020
Merged
@AdrianOlosutean AdrianOlosutean mentioned this issue Jul 15, 2020
Merged
@AdrianOlosutean AdrianOlosutean self-assigned this Jul 15, 2020
@AdrianOlosutean
Copy link
Contributor

Release notes:
Fixed potential erroneous runPostProcessing warning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AdrianOlosutean AdrianOlosutean

Labels
bug Something isn't working Conformance Conformance Job affected priority: low Nice to have Standardization Standardization Job affected UX Something concerning UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/1371 Combined Standardization Conformance Job AbsaOSS/enceladus
2 participants
@AdrianOlosutean @Zejnilovic