Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy issuer credential #116

Merged
merged 5 commits into from
Sep 25, 2020
Merged

Conversation

mirgee
Copy link
Contributor

@mirgee mirgee commented Sep 25, 2020

Signed-off-by: Miroslav Kovar miroslavkovar@protonmail.com

Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
Base automatically changed from cleanup/credentials to master September 25, 2020 11:19
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
@mirgee mirgee changed the title WIP: Remove legacy issuer credential Remove legacy issuer credential Sep 25, 2020
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #116 into master will increase coverage by 0.90%.
The diff coverage is 51.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #116      +/-   ##
==========================================
+ Coverage   48.36%   49.27%   +0.90%     
==========================================
  Files         124      124              
  Lines       24809    24219     -590     
  Branches     6733     6525     -208     
==========================================
- Hits        12000    11933      -67     
+ Misses       9040     8538     -502     
+ Partials     3769     3748      -21     
Flag Coverage Δ
#unittests 49.27% <51.47%> (+0.90%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libvcx/src/credential.rs 56.73% <0.00%> (+7.56%) ⬆️
libvcx/src/messages/get_message.rs 36.89% <0.00%> (-0.12%) ⬇️
libvcx/src/v3/messages/issuance/credential.rs 82.50% <ø> (+28.40%) ⬆️
...ibvcx/src/v3/messages/issuance/credential_offer.rs 77.14% <ø> (+23.67%) ⬆️
libvcx/src/issuer_credential.rs 60.00% <62.50%> (+35.03%) ⬆️
libvcx/src/api/issuer_credential.rs 38.57% <83.33%> (-3.66%) ⬇️
libvcx/src/v3/handlers/issuance/states.rs 51.37% <0.00%> (ø)
libvcx/src/lib.rs 33.71% <0.00%> (+0.15%) ⬆️
libvcx/src/v3/handlers/issuance/issuer.rs 66.41% <0.00%> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a1c695...121cd94. Read the comment docs.

Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
@Patrik-Stas Patrik-Stas merged commit 74c09b9 into master Sep 25, 2020
@Patrik-Stas Patrik-Stas deleted the cleanup/issuer-credential branch September 25, 2020 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants