Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail earlier on duplicated transactions #1154

Closed
wajda opened this issue Jan 13, 2023 · 2 comments
Closed

Fail earlier on duplicated transactions #1154

wajda opened this issue Jan 13, 2023 · 2 comments
Assignees
@wajda
Labels
component: Persistence enhancement
Milestone
1.0.0

Comments

@wajda
Copy link
Contributor

wajda commented Jan 13, 2023

Current implementation allows multiple transactions to start inserting duplicated data, but only one of them can succeed due to a unique index on ExecutionPlan._key. Although this solution is sufficient, we could probably do even better by resolving the duplication at the moment of transaction start.
@wajda wajda added this to the 1.0.0 milestone Jan 13, 2023
@wajda wajda self-assigned this Jan 13, 2023
@wajda
Copy link
Contributor Author

wajda commented Jan 18, 2023

it partially overlaps with #1155 and needs to be thought over together or after #1155 is done.

@wajda
Copy link
Contributor Author

wajda commented Jul 16, 2024

It's fully covered by #1155 after introducing a lock mechanism based on secondary transaction ID (SID) that represents that business key of the entity being inserted. So no further action needed to implement the ticket.

@wajda wajda closed this as completed Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wajda wajda

Labels
component: Persistence enhancement
Projects
Spline
Status: Done
Milestone
1.0.0
Development

No branches or pull requests
1 participant
@wajda