-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kafka :: message failure handling #1279
Labels
Milestone
Comments
Are you sure? I thought it will not acknowledge the message if the underlying layer throws an error. |
Yes, I'm sure. I specifically verified it yesterday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem
At the moment the Kafka consumer is implemented in a way that all messages are automatically acknowledged regardless if the processing was successful or not. This would lead to data loss in case of database failure, or a processing timeout due to the message size, for example.
Goal
We need to implement a robust error handling strategy.
Solution proposal
Based on the error type, we can decide if the error is persistent or temporary and apply different logic for each type:
Persistent errors
The error is considered persistent if it's evident or very likely that the error would re-occur on any retry processing attempt in the future. For example, the message is malformed or invalid, or it contradicts the current state of the database (e.g. constraint violation) . In such cases we would acknowledge the message and send it to the dead letters topic, where it would sit and wait manual intervention.
Temporary errors
It the database is experiencing issues, an unexpected error happens in the app code, or a message dependency aren't fulfilled, we know that the situation that lead to the error is rather temporary and might be fixed soon. In that case we would acknowledge the message and send it to a retry topic, from where the messaged would be automatically pulled and retried periodically.
The text was updated successfully, but these errors were encountered: