Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to yaml 0.7.0 #1466

Closed
hodoulp opened this issue Aug 24, 2021 · 6 comments
Closed

Update to yaml 0.7.0 #1466

hodoulp opened this issue Aug 24, 2021 · 6 comments

Comments

@hodoulp
Copy link
Member

hodoulp commented Aug 24, 2021

Following the fix for vcpkg (#1449), I found that vcpkg compiles OpenColorIO 2.0.1 against yaml 0.7.0. That's the latest version of yaml, and we never validated that combination.

For 2.1.x we should think about updating yaml.

For 2.0.x I suggest to also update yaml. To be discussed at the TSC meeting i.e. what is the policy for the mandatory third-party library update (those not part of the VFX Reference platform)?

Links:
https://github.com/jbeder/yaml-cpp/releases/tag/yaml-cpp-0.7.0
jbeder/yaml-cpp@yaml-cpp-0.6.3...yaml-cpp-0.7.0

@hodoulp
Copy link
Member Author

hodoulp commented Aug 25, 2021

Note: Have a look to #1451 to improve/fix it.

@riots100
Copy link

I am also getting an exception when trying to run OCIO v2.0.1 installed via VCPKG. The exception is happening in both YAML-cpp 0.7.0 and 0.6.3
Stack Trace:
1 OpenColorIO_2_0.dll!std::_Ptr_baseYAML::detail::node_ref::get() <-- CRASH HERE
2 OpenColorIO_2_0.dll!std::shared_ptrYAML::detail::node_ref::operator
YAML::detail::node_ref,0()
3 OpenColorIO_2_0.dll!YAML::detail::node::get<char [21]>(const char[21] & key, std::shared_ptrYAML::detail::memory_holder pMemory)
4 OpenColorIO_2_0.dll!YAML::Node::operator[]<char [21]>(const char[21] & key)
5 OpenColorIO_2_0.dll!OpenColorIO_v2_0::`anonymous namespace'::load(const YAML::Node & node, std::shared_ptr<OpenColorIO_v2_0::Config> & config, const char * filename)
6 OpenColorIO_2_0.dll!OpenColorIO_v2_0::OCIOYaml::Read(std::basic_istream<char,std::char_traits> & istream, std::shared_ptr<OpenColorIO_v2_0::Config> & config, const char * filename)
7 OpenColorIO_2_0.dll!OpenColorIO_v2_0::Config::Impl::Read(std::basic_istream<char,std::char_traits> & istream, const char * filename)
8 OpenColorIO_2_0.dll!OpenColorIO_v2_0::Config::CreateFromStream(std::basic_istream<char,std::char_traits> & istream)
9 OpenColorIO_2_0.dll!OpenColorIO_v2_0::Config::CreateRaw()

@remia
Copy link
Collaborator

remia commented Aug 31, 2021

Trying yaml 0.7.0 on mac OS 11.5.2, master branch, I didn't hit any major issues. Fixes have to be made on the unit test suite related to multi-lines comment fields no longer having spaces on empty lines, but that's pretty much it.

@riots100
Copy link

Trying yaml 0.7.0 on mac OS 11.5.2, master branch, I didn't hit any major issues. Fixes have to be made on the unit test suite related to multi-lines comment fields no longer having spaces on empty lines, but that's pretty much it.

I didn't have this issue on OSX with the same code base. Only issue is on Windows 10.

@remia
Copy link
Collaborator

remia commented Oct 9, 2021

@riots100 Do you have anything new on this error ? If not, can you give more details on how to reproduce it ? Thanks.

@hodoulp
Copy link
Member Author

hodoulp commented Dec 9, 2021

merged in main.

@hodoulp hodoulp closed this as completed Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants