Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Platform/OS dependent piz compressed binary data #632

Closed
arkellr opened this issue Dec 13, 2019 · 2 comments
Closed

Platform/OS dependent piz compressed binary data #632

arkellr opened this issue Dec 13, 2019 · 2 comments
Labels
Enhancement A request for a change or enhancement.
Milestone

Comments

@arkellr
Copy link
Contributor

arkellr commented Dec 13, 2019

Just pasting my commit comment which best describe this issue and fix. Will PR it shortly... but creating "an issue" for it first.

OpenEXR/IlmImf/ImfHuf.cpp: Fix OS dependent exr binary data for piz.

Issue: piz compressed binary data was OS dependent e.g. different betw linux
and osx. For example if one did a md5 checksum on the compressed data of an
exr with identical image pixel/channel data it would return different checksums on linux and osx for the Piz compressor.

This was due to the fact that the decoding huffman table stored, while having
the same entries on linux and osx were sorted differently due to the differing
behavior of STL heap sort for decode table entries that were equivalent.

Fix was to simply update the heap compare operator to also handled this
equality case.

Updated: OpenEXR/IlmImfTest/testHuf.cpp to test for identical platform/os
piz compressed exr file data blocks.
@cary-ilm cary-ilm added the Needs Discussion To be discussed in the technical steering committee label Jan 9, 2020
@cary-ilm
Copy link
Member

cary-ilm commented Jan 9, 2020

@arkellr, were you going to submit a PR?

@cary-ilm
Copy link
Member

cary-ilm commented Feb 6, 2020

Closing the issue since the PR is in, #637.

@cary-ilm cary-ilm closed this as completed Feb 6, 2020
@cary-ilm cary-ilm added Enhancement A request for a change or enhancement. and removed Needs Discussion To be discussed in the technical steering committee labels Feb 7, 2020
@cary-ilm cary-ilm added this to the Next Minor Release milestone Feb 7, 2020
@cary-ilm cary-ilm modified the milestones: Next Minor Release, v2.5.0 Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement A request for a change or enhancement.
Projects
None yet
Development

No branches or pull requests

2 participants